-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@powerpages][5x5] Update Webpage Content and Create Site Records on DV #1073
Open
amitjoshi438
wants to merge
32
commits into
main
Choose a base branch
from
users/amitjoshi/@powerpagesCreateSiteRecordsOnDV
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[@powerpages][5x5] Update Webpage Content and Create Site Records on DV #1073
amitjoshi438
wants to merge
32
commits into
main
from
users/amitjoshi/@powerpagesCreateSiteRecordsOnDV
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lyFileSystemProvider for site page previews
… CreateSiteHelper to utilize it
…omponents for site creation functionality
…ions and improve readability; add CreateSiteTypes for better type management
…ors in previewSitePagesContent function
…in EditableFileSystemProvider
… user inputs in CreateSiteHelper
…ntOptions interface
…eter for API calls
…tps://github.com/microsoft/powerplatform-vscode into users/amitjoshi/@powerpagesCreateSiteRecordsOnDV
…les for site pages
…itableFileSystemProvider for improved content management
priyanshu92
reviewed
Dec 18, 2024
src/common/chat-participants/powerpages/commands/create-site/CreateSiteHelper.ts
Outdated
Show resolved
Hide resolved
src/common/chat-participants/powerpages/commands/create-site/CreateSiteHelper.ts
Outdated
Show resolved
Hide resolved
src/common/chat-participants/powerpages/commands/create-site/CreateSiteModel.ts
Show resolved
Hide resolved
src/common/chat-participants/powerpages/commands/create-site/CreateSiteUtils.ts
Outdated
Show resolved
Hide resolved
src/common/chat-participants/powerpages/commands/create-site/SiteComponents.ts
Outdated
Show resolved
Hide resolved
src/common/chat-participants/powerpages/commands/create-site/CreateSiteUtils.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the localization files and the
PowerPagesChatParticipant
class to improve error messaging, site creation, and file system handling. The most important changes include updates to localization strings, modifications to thePowerPagesChatParticipant
class to register a new content provider, and updates to the command execution logic.Localization updates:
l10n/bundle.l10n.json
andloc/translations-export/vscode-powerplatform.xlf
. [1] [2]Enhancements to
PowerPagesChatParticipant
:EditableFileSystemProvider
to handle file system operations related to site creation.CommandRegistry
andPowerPagesChatParticipant
classes to pass theEditableFileSystemProvider
to commands. [1] [2]Command execution improvements:
CreateSiteCommand
class to include theEditableFileSystemProvider
in its execution logic, enabling better handling of file system operations during site creation. [1] [2]Telemetry updates:
VSCODE_EXTENSION_POPULATE_SITE_RECORDS_START
andVSCODE_EXTENSION_CREATE_SITE_OPERATION_SUCCESS
.These changes collectively enhance the functionality and user experience of the Power Pages site creation process in the VS Code extension.